Fix incorrect F-test denominator assignments in TwoWayAnovaModel#350
Merged
kMutagene merged 5 commits intofslaborg:datasciencefrom Oct 21, 2025
Merged
Fix incorrect F-test denominator assignments in TwoWayAnovaModel#350kMutagene merged 5 commits intofslaborg:datasciencefrom
kMutagene merged 5 commits intofslaborg:datasciencefrom
Conversation
Member
|
@LibraChris can you rebase this onto the latest |
- 'Fixed' case was incorrectly using Random logic - 'Random' case was using Mixed logic - 'Mixed' case was using Fixed logic Corrected F-test denominator assignments for each TwoWayAnovaModel type.
LibraChris
force-pushed
the
anova_update
branch
from
8095450 to
e7cf1fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #349
Changes introduced in this PR
Description
This PR resolves incorrect F-test denominator assignments in the TwoWayAnovaModel implementation.
Previously:
These errors resulted in incorrect statistical outputs. The logic has been corrected, and the test coverage ensures accurate results for all model types.
[Required] please make sure you checked that
[Optional]