Conversation
Codecov Report
@@ Coverage Diff @@
## developer #203 +/- ##
=============================================
+ Coverage 29.49% 31.50% +2.00%
=============================================
Files 123 124 +1
Lines 11610 11644 +34
Branches 2036 1784 -252
=============================================
+ Hits 3424 3668 +244
+ Misses 7649 7535 -114
+ Partials 537 441 -96
Continue to review full report at Codecov.
|
bvenn
requested changes
May 27, 2022
Comment on lines
+27
to
+29
| "data": { | ||
| "text/html": [ | ||
| "<div><div><strong>Restore sources</strong><ul><li><span> C:/Users/schne/source/repos/fslaborg/FSharp.Stats/pkg</span></li></ul></div><div></div><div><strong>Installed Packages</strong><ul><li><span>FSharp.Stats, 0.0.0-dev</span></li><li><span>FSharp.Stats.Interactive, 0.0.0-dev</span></li></ul></div></div>" |
Member
There was a problem hiding this comment.
Do you want the cell outputs to be preserved?
Member
Author
There was a problem hiding this comment.
Yes- i thought it would be nice that you can directly see the output when looking at the sample notebook on github
| "\n", | ||
| "The version of the package is always `0.0.0-dev`.\n", | ||
| "\n", | ||
| "To rre-run the build/repack you have to restart the notebook kernel, otherwise we cannot remove the referenced local nuget package." |
| | :? System.Double as f -> | ||
| match f with | ||
| | f when f <= -10000. -> sprintf "%.2g" f | ||
| | f when f < 0. -> sprintf "%.2f" f |
| @@ -0,0 +1,86 @@ | |||
| module FormattingTests | |||
Member
There was a problem hiding this comment.
Are nans and infinities printed properly?
Member
Author
There was a problem hiding this comment.
I added tests for both individual formatting and a matrix containing mixed values of all cases.
bvenn
approved these changes
May 27, 2022
| "data": { | ||
| "text/html": [ | ||
| "<div><div><strong>Restore sources</strong><ul><li><span> C:/Users/schne/source/repos/fslaborg/FSharp.Stats/pkg</span></li></ul></div><div></div><div><strong>Installed Packages</strong><ul><li><span>FSharp.Stats, 0.0.0-dev</span></li><li><span>FSharp.Stats.Interactive, 0.0.0-dev</span></li></ul></div></div>" | ||
| "<div><div><strong>Restore sources</strong><ul><li><span> C:/Users/schne/source/repos/fslaborg/FSharp.Stats/pkg</span></li></ul></div><div></div><div><strong>Installed Packages</strong><ul><li><span>FSharp.Stats, 0.0.1-dev</span></li><li><span>FSharp.Stats.Interactive, 0.0.1-dev</span></li></ul></div></div>" |
Member
There was a problem hiding this comment.
In L11 you wrote "The version of the package is always 0.0.0-dev.", but here you changed it to 0.0.1-dev. Is that intended?
bvenn
approved these changes
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a formatting extension for .NET interactive, providing a formatter for the
Matrix<'T>type as a POC, tightly oriented on my work for the Deedle.Interactive extension (fslaborg/Deedle#547). When both are merged, we will have a nice consistent display across both libs.It completely overhauls the formatting for matrices as well, replacing the current
StructuredFormatDisplayand making the FSI printer obsolete.While i have confidence in it, pls do not merge before i added tests 😆
An example notebook can be seen here.
Notebook screenshot:
FSI screenshot: