Fixes for Gamma.incompleteUpper#196
Merged
bvenn merged 2 commits intofslaborg:developerfrom Apr 26, 2022
Merged
Conversation
Member
|
see #195 for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please reference the issue(s) this PR is related to
The problem is described here
Fixes #195
Please list the changes introduced in this PR
"test_gammaincupperinf"now checks that upperGamma evaluates to 0 when the second argument is infinite (before the test wrongly asserted this result should be 1).[Required] please make sure you checked that
[Optional]
I didn't add any new tests besides fixing the one mentioned above, but I checked that the results of upperGamma agree with an implementation in another language.