You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I'm reading the failed checks correctly, I got 'unlucky' with the random numbers for the test vector / test matrix.
It does not seem like a problem in the code itself, just that Cholesky is relatively unstable.
I will hard code a testcase instead.
Oh I just noticed that I was giving the univariable testcase the same y as the multivariable case, which has a bigger error term. I fixed that.
Would it still be better style to have a hardcoded testcase, than a random one?
If the test with random samples may fail, a discrete case is preferred. Otherwise a hypothetical failure in the future would lead to unnecessary confusion while the methods works perfectly fine. If a failure of this method should be impossible the test you provided seems fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to FSharp.Stats. Please take the time to tell us a bit more about your PR.
This is related to Issue #162
Closes #162
Please list the changes introduced in this PR