Conversation
…154 Frame.join and Frame.joinAlign both take `kind` as their first parameter. Frame.joinOn, joinOnString, and joinOnInt had the order reversed (`colKey` before `kind`), making them inconsistent and surprising for callers who compose them with the other join operators. This commit swaps the parameters so all three functions now follow the same convention as `join`: // Before (inconsistent) Frame.joinOnString "id" JoinKind.Inner left right // After (consistent with Frame.join) Frame.joinOnString JoinKind.Inner "id" left right Changes: - FrameModule.fs: swap `colKey`/`kind` in joinOn, joinOnString, joinOnInt - Frame.fs (tests): update all call sites to new parameter order - Frame.fs (tests): add right-join test for joinOnString and outer-join test for joinOnInt to give full coverage of all four JoinKind values Co-authored-by: Copilot <[email protected]>
dsyme
deleted the
repo-assist/fix-issue-154-joinOn-param-order-e1eed0df9247b2c0
branch
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Repo Assist — implementing the
Frame.joinOnconsistency fix requested by @dsyme in #154.Problem
Frame.joinandFrame.joinAlignboth takekindas their first parameter, so callers can naturally write:But
Frame.joinOn,Frame.joinOnString, andFrame.joinOnInthad the order reversed (colKeybeforekind):This was surprising and made the three functions feel like second-class citizens compared to the rest of the join family.
Fix
Swap the parameters so
kindcomes first in all three functions, matchingjoin:All 672 tests pass (2 new tests added).