Conversation
closes #76 The existing functions indexRowsDate and indexRowsDateOffs have abbreviated names that don't clearly reflect the types they return. Add explicit-named aliases indexRowsDateTime and indexRowsDateTimeOffset that are more self-documenting and consistent with the type names. The original functions are kept unchanged for backward compatibility; the new names are purely additive aliases. Co-authored-by: Copilot <[email protected]>
9 tasks
Member
|
/repo-assist Make the old names obsolete |
Add [<Obsolete>] attributes directing users to the new explicit names: - indexRowsDate → indexRowsDateTime - indexRowsDateOffs → indexRowsDateTimeOffset Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
Commit pushed:
|
Contributor
Author
|
🤖 Repo Assist here. Done! I've added
Users calling the old names will now get a compiler warning directing them to the new explicit names. The new
|
dsyme
deleted the
repo-assist/fix-issue-76-indexRowsDateTime-3c4ea72bdfceac64
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Repo Assist — adding explicit-named aliases for the date indexing functions.
Problem
Frame.indexRowsDateandFrame.indexRowsDateOffshave abbreviated names that obscure what type they return. In a discoverable API it's much clearer to seeindexRowsDateTimeandindexRowsDateTimeOffset, which match the .NET type names directly. The maintainer approved this in #76 back in 2014 but it was never implemented.Solution
Add two explicit-named aliases in
FrameModule.fs:All 669 tests pass on Ubuntu.