Conversation
Task 5 (Coding Improvement): Add Frame.indexRowsApply column f
- Indexes by a column key and transforms the resulting row keys
through a user-supplied function f
- Closes #206 (requested by @tpetricek)
- Added to F# module (FrameModule.fs) and C# extensions (FrameExtensions.fs)
- Added 1 test; all 670 tests pass
Task 4 (Engineering Investment): Fix build.ps1 version extraction
- Directory.Build.props uses an MSBuild-evaluated <Version> expression
- The previous PowerShell code read the raw XML attribute (returning the
literal MSBuild expression string) instead of the resolved version
- Fixed to read the version from RELEASE_NOTES.md directly, matching
the approach already used in build.sh
Co-authored-by: Copilot <[email protected]>
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Repo Assist — two improvements in this PR (Tasks 4 & 5 for this run).
Task 5: Add
Frame.indexRowsApply— closes #206A new
Frame.indexRowsApplyfunction that indexes a frame by a specified column and applies a transformation function to the resulting keys. This directly implements the feature requested in #206.Before: users had to chain two calls:
After:
Implementation
FrameModule.fs: addslet indexRowsApply column (f:'V -> 'R2) (frame:Frame<'R1,'C>) : Frame<'R2, _>Defined after
mapRowKeys(which it calls), in the "Sorting and index manipulation" category.FrameExtensions.fs: adds matchingIndexRowsApply(frame, column, f:Func<'V,'R2>)extension for C# users.tests/Deedle.Tests/Frame.fs: adds 1 test covering the core behaviour (string-column parsed tointkeys).Task 4: Fix
build.ps1version extraction bugDirectory.Build.propsuses an MSBuild property expression for(Version):The previous PowerShell code tried to read this as a static XML attribute:
This returned the literal MSBuild expression string rather than the resolved version number, causing
fsdocsto be invoked with a garbled version. The fix reads fromRELEASE_NOTES.mddirectly — consistent withbuild.sh: