Conversation
Add an optional 'typeResolver' parameter (type: string -> string option) to all F#-friendly ReadCsv/ReadCsvString overloads and the underlying readCsv/readString functions in FrameUtils. The resolver is called with each column header name. Returning Some "type" (e.g. Some "int", Some "float", Some "bool") pins that column's type; returning None lets Deedle infer it as normal. When both 'typeResolver' and 'schema' are provided, the explicit 'schema' takes precedence for any column it names, preventing duplicate schema entries from exceeding the column-count limit in the schema parser. Implementation: the resolver generates 'ColName=Type' named-override entries for all applicable columns, filters out any column already covered by the explicit schema, and passes the combined string to the existing InferColumnTypes machinery. Co-authored-by: Copilot <[email protected]>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Repo Assist — implementing #454 as requested by @dsyme.
Summary
This PR adds an optional
typeResolverparameter to all F#-friendlyFrame.ReadCsvandFrame.ReadCsvStringoverloads, implementing the feature proposed in #454.What it does
Two new tests added:
typeResolver maps column names to types— basic resolver usagetypeResolver explicit schema takes precedence over typeResolver— conflict resolutionCloses #454