Conversation
…functions (closes #191) Expose the existing Series member slicing methods (Before, After, StartAt, EndAt, Between) as F#-style module functions in the Series module, enabling idiomatic pipe- line usage. Add matching Frame.rowsBefore / rowsAfter / rowsStartAt / rowsEndAt / rowsBetween module functions for frame row range selection. Add 6 regression tests (5 for Series, 1 for Frame). Co-authored-by: Copilot <[email protected]>
9 tasks
dsyme
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Exposes the existing
Seriesmember slicing methods (Before,After,StartAt,EndAt,Between) as F#-style module functions, and adds matchingFrame.rows*module functions for row range selection. Closes #191.Motivation
The member methods have existed for a long time but were not available as
Series.xxxpipe-able module functions, forcing users to mix member-call syntax (series.After(k)) with pipeline style in F# code. This is the gap called out in #191 ("It's irksome to mix|>and member styles at times").New functions
SeriesmoduleSeries.after lowerExclusive seriesseries.After(k)Series.before upperExclusive seriesseries.Before(k)Series.startAt lowerInclusive seriesseries.StartAt(k)Series.endAt upperInclusive seriesseries.EndAt(k)Series.between lo hi seriesseries.Between(lo, hi)FramemoduleFrame.rowsAfter lowerExclusive frameFrame.rowsBefore upperExclusive frameFrame.rowsStartAt lowerInclusive frameFrame.rowsEndAt upperInclusive frameFrame.rowsBetween lo hi frameUsage
Implementation notes
frame.GetSubrange(lo, hi)with the appropriateBoundaryBehavioroptions, consistent with howFrame.fsuses it internally.open Deedle.IndicestoFrameModule.fsto bringBoundaryBehaviorinto scope.Test Status
✅ All 500 tests pass (494 baseline + 6 new tests)
New tests added:
Series.after module function matches member AfterSeries.before module function matches member BeforeSeries.startAt module function matches member StartAtSeries.endAt module function matches member EndAtSeries.between module function returns inclusive rangeFrame.rowsAfter, rowsBefore, rowsStartAt, rowsEndAt, rowsBetween work on ordered int keys