Propagate missing values in Stats.cov from Stats.stdDev.#552
Propagate missing values in Stats.cov from Stats.stdDev.#552zyzhu merged 1 commit intofslaborg:masterfrom
Conversation
| |> Frame.addCol "B" (series []) | ||
|
|
||
| cov | ||
| |> Frame.toMatrix |
There was a problem hiding this comment.
I tried to just write this as cov |> shouldEqual expected but something was throwing the equality check off. I would guess some reference equality somewhere. Should shouldEqual work for two frames with the same contents? I'd like to write it as an equality on the frames if possible as that's a more correct assertion.
|
Hi, is there anything I can do to help get the ubuntu build passing? It looks like a server setup issue and not related to the code change, but I'd be happy to chip in if it helps move this PR along. |
|
Sorry that I have been traveling and forgot to merge this pull. It looks great. Thanks for fixing it. I'll release the fix to nuget soon. |
|
Hi @zyzhu did you manage to get around to releasing this fix? I don't see it on NuGet yet. Thanks. |
|
Sorry about the delay. I had some problems with the build environment on my laptop. Just got it figured out. Version 3.0.0 is just released on Nuget. |
|
Amazing. Thanks for the quick turnaround today 🙌 |
2 participants
Addresses #551