Add util, extension and test to read a frame from a CSV string#530
Merged
zyzhu merged 3 commits intofslaborg:masterfrom Jul 6, 2021
kMutagene:master
Merged
Add util, extension and test to read a frame from a CSV string#530zyzhu merged 3 commits intofslaborg:masterfrom kMutagene:master
zyzhu merged 3 commits intofslaborg:masterfrom
kMutagene:master
Conversation
Contributor
|
Thanks for the addition. I've released 2.4.0 on nuget. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Frame extension that can read CSV from a string.
Currently, two extra steps are needed to do that: reading the bytes from the string, and passing a
MemoryStreambased on that toFrame.ReadCsv:Why add this?
While this saves 'only' 2 LOC in scripts, this is a common operation when getting data via HTTP requests and therefore justifies the addition IMHO. This happens often when analyzing data from online sources. Examples where i use it can be seen in the Plotly.NET docs
I added a test based on the tests already implemented. If i should add more or change something, please let m know ;)