Document the run-time behaviour of numeric Deedle.Stats functions#501
Merged
zyzhu merged 1 commit intofslaborg:masterfrom Jun 15, 2020
Merged
Document the run-time behaviour of numeric Deedle.Stats functions#501zyzhu merged 1 commit intofslaborg:masterfrom
zyzhu merged 1 commit intofslaborg:masterfrom
Conversation
Add an XML comment to Deedle.Stats functions that implicitly convert the generic value type of an input series to float, stating that the operation may fail with a FormatException or an InvalidCastException.
Arlofin
referenced
this pull request
Jun 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up this discussion.
Make it visible to the user if a function in Deedle.Stats implicitly converts the values of a series to float and thus fails at run-time if it cannot be done.