Skip to content

Raise IndexOutOfRangeException warning when accessing empty series by index#437

Merged
zyzhu merged 2 commits intofslaborg:masterfrom
zyzhu:issue-365
Aug 21, 2018
Merged

Raise IndexOutOfRangeException warning when accessing empty series by index#437
zyzhu merged 2 commits intofslaborg:masterfrom
zyzhu:issue-365

Conversation

@zyzhu
Copy link
Copy Markdown
Contributor

@zyzhu zyzhu commented Aug 21, 2018

To address #365

@alexpantyukhin
Copy link
Copy Markdown
Contributor

For example for the method Get I think that there is no need to check that series is empty. Because in common, anyway it means missingVal. What do you think?

@zyzhu
Copy link
Copy Markdown
Contributor Author

zyzhu commented Aug 21, 2018

You are right. IndexOutOfRangeException shall just be raised for accessing by index only. I'll simplify it.

@zyzhu zyzhu changed the title Raise IndexOutOfRangeException warning when accessing empty series Raise IndexOutOfRangeException warning when accessing empty series by index Aug 21, 2018
@zyzhu zyzhu merged commit 02e1a90 into fslaborg:master Aug 21, 2018
@zyzhu zyzhu deleted the issue-365 branch August 22, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants