Skip to content

Add pointwise parameter in frame1.zip#434

Merged
zyzhu merged 2 commits intofslaborg:masterfrom
zyzhu:issue-432
Aug 21, 2018
Merged

Add pointwise parameter in frame1.zip#434
zyzhu merged 2 commits intofslaborg:masterfrom
zyzhu:issue-432

Conversation

@zyzhu
Copy link
Copy Markdown
Contributor

@zyzhu zyzhu commented Aug 21, 2018

To address #432

  1. Added pointwise parameter in frame1.zip. If false, the unmatched column will be missing. If true, the column will be left unchanged.
  2. Adjusted PointwiseFrameFrame to call frame1.zip with pointwise set to be true
  3. Adjusted zipAlign with pointwise set to be false to keep the original behavior
  4. Added unit test

@zyzhu zyzhu merged commit a62e514 into fslaborg:master Aug 21, 2018
@zyzhu zyzhu deleted the issue-432 branch August 22, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant