Skip to content

Removed compiler warning from ReadCsv#426

Merged
zyzhu merged 1 commit intofslaborg:masterfrom
zyzhu:issue-417
Aug 15, 2018
Merged

Removed compiler warning from ReadCsv#426
zyzhu merged 1 commit intofslaborg:masterfrom
zyzhu:issue-417

Conversation

@zyzhu
Copy link
Copy Markdown
Contributor

@zyzhu zyzhu commented Aug 15, 2018

To address issue #417

I looked into FrameExtensions.fs. Calling Frame.ReadCsv with the following cases will always overload the function that's intended for C# use because the signature is identical to F# implementation.

  1. Only path string
  2. Path string and other optional string parameters such as schema, separators and culture.

But the implementation of the function are essentially the same. It's ok to let F# code calling the overload that's intended for C# in the above cases. Hence I removed the compiler warning to avoid confusion.

@zyzhu zyzhu merged commit 5bff5ee into fslaborg:master Aug 15, 2018
@zyzhu zyzhu deleted the issue-417 branch August 15, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant