Removed compiler warning from ReadCsv#426
Merged
zyzhu merged 1 commit intofslaborg:masterfrom Aug 15, 2018
zyzhu:issue-417
Merged
Removed compiler warning from ReadCsv#426zyzhu merged 1 commit intofslaborg:masterfrom zyzhu:issue-417
zyzhu merged 1 commit intofslaborg:masterfrom
zyzhu:issue-417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address issue #417
I looked into FrameExtensions.fs. Calling Frame.ReadCsv with the following cases will always overload the function that's intended for C# use because the signature is identical to F# implementation.
But the implementation of the function are essentially the same. It's ok to let F# code calling the overload that's intended for C# in the above cases. Hence I removed the compiler warning to avoid confusion.