Skip to content

Fix aggregateRowsBy in Issue 375#408

Merged
zyzhu merged 1 commit intofslaborg:masterfrom
zyzhu:issue-375
Aug 8, 2018
Merged

Fix aggregateRowsBy in Issue 375#408
zyzhu merged 1 commit intofslaborg:masterfrom
zyzhu:issue-375

Conversation

@zyzhu
Copy link
Copy Markdown
Contributor

@zyzhu zyzhu commented Aug 8, 2018

Attempt to fix #375

  1. Get all values of groupBy including missing values
  2. Added test
sample:
     A         B C 
1 -> 10        1 1 
2 -> <missing> 2 2 
3 -> 10        1 3 
4 -> <missing> 2 4 
5 -> 10        3 5

operation:
sample |> Frame.aggregateRowsBy ["A";"B"] ["C"] Stats.mean

expected:
     A         B C 
0 -> 10        1 2 
1 -> <missing> 2 3 
2 -> 10        3 5

@zyzhu zyzhu merged commit c07d8d9 into fslaborg:master Aug 8, 2018
@zyzhu zyzhu deleted the issue-375 branch August 9, 2018 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suspicious result of AggregateRowsBy

1 participant