Skip to content

RFC-1089: allow the use of the 'string' function everywhere #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cartermp merged 7 commits into from
Aug 23, 2020
Merged

RFC-1089: allow the use of the 'string' function everywhere #479

cartermp merged 7 commits into from
Aug 23, 2020

Conversation

@abelbraaksma
Copy link
Member

@abelbraaksma abelbraaksma commented Jun 28, 2020 •
edited
Loading

As in the title, belongs to language suggestion: fsharp/fslang-suggestions#890.

This changes the behavior of the FSharp.Core string function slightly to allow its use in situations where it was previously not allowed, like in an overloaded ToString() member.

In addition, it addresses the fact that the original optimization paths were never executed.

This was referenced Jun 28, 2020
Closed
Merged
@abelbraaksma abelbraaksma changed the title Tentative RFC-1089 for allowing 'string' in more contexts in code RFC-1089: allow the use of the 'string' function everywhere Jul 11, 2020
@abelbraaksma
Copy link
Member Author

abelbraaksma commented Aug 23, 2020 •
edited
Loading

@cartermp, considering that the PR dotnet/fsharp#9549 has now been merged, I've updated the corresponding RFC to reflect the decisions there. Perhaps this can be merged and the related lang-suggestion be accepted-in-principle?

cartermp
cartermp approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny change

@abelbraaksma
Copy link
Member Author

abelbraaksma commented Aug 23, 2020 •
edited
Loading

tiny change

@cartermp tx, done :)

@cartermp cartermp merged commit b82e5d4 into fsharp:master Aug 23, 2020
@abelbraaksma abelbraaksma deleted the RFC-1089-string-everywhere branch August 23, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cartermp cartermp cartermp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abelbraaksma @cartermp