RFC-1089: allow the use of the 'string' function everywhere#479
Merged
cartermp merged 7 commits intofsharp:masterfrom Aug 23, 2020
Merged
RFC-1089: allow the use of the 'string' function everywhere#479cartermp merged 7 commits intofsharp:masterfrom
cartermp merged 7 commits intofsharp:masterfrom
Conversation
abelbraaksma
changed the title
Member
Author
|
@cartermp, considering that the PR dotnet/fsharp#9549 has now been merged, I've updated the corresponding RFC to reflect the decisions there. Perhaps this can be merged and the related lang-suggestion be accepted-in-principle? |
cartermp
approved these changes
Aug 23, 2020
Co-authored-by: Phillip Carter <[email protected]>
Member
Author
@cartermp tx, done :) |
cartermp
approved these changes
Aug 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in the title, belongs to language suggestion: fsharp/fslang-suggestions#890.
This changes the behavior of the FSharp.Core
stringfunction slightly to allow its use in situations where it was previously not allowed, like in an overloadedToString()member.In addition, it addresses the fact that the original optimization paths were never executed.