Skip to content

Deduplicate module names #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsyme merged 1 commit into from
Mar 31, 2017
Merged

Deduplicate module names #748

dsyme merged 1 commit into from
Mar 31, 2017

Conversation

@alfonsogarciacaro
Copy link
Contributor

@alfonsogarciacaro alfonsogarciacaro commented Mar 31, 2017

@dsyme dsyme merged commit 06e8743 into fsharp:master Mar 31, 2017
@dsyme
Copy link
Contributor

dsyme commented Mar 31, 2017

Released as FCS 12.0.2

alfonsogarciacaro added a commit to alfonsogarciacaro/FSharp.Compiler.Service that referenced this pull request Mar 31, 2017
@alfonsogarciacaro
Add test for fsharp#748
7563e39
@alfonsogarciacaro
Copy link
Contributor Author

alfonsogarciacaro commented Mar 31, 2017

I updated the FCS dependency in Fable to 12.0.2 and I'm still having the same problem. @forki warned it was possible the fix didn't apply to FCS. I sent a specific test for FCS in #749. Sad.

dsyme pushed a commit that referenced this pull request Apr 3, 2017
@alfonsogarciacaro @dsyme
[WIP] Add test for #748 (#749)
4a231d9 
* Add test for #748

* Improve test output

* Fix attempt

* Deduplicate the deduplication code
@alfonsogarciacaro alfonsogarciacaro mentioned this pull request Oct 4, 2017
Closed
@abelbraaksma abelbraaksma mentioned this pull request Mar 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alfonsogarciacaro @dsyme