gro: change the BUG_ON() in gro_pull_from_frag0()

edumazet · kuba-moo · commit cbe41362be2c · 2026-01-25T13:18:52.000-08:00
Replace the BUG_ON() which never fired with a DEBUG_NET_WARN_ON_ONCE() $ scripts/bloat-o-meter -t vmlinux.1 vmlinux.2 add/remove: 2/2 grow/shrink: 1/1 up/down: 370/-254 (116) Function old new delta gro_try_pull_from_frag0 - 196 +196 napi_gro_frags 771 929 +158 __pfx_gro_try_pull_from_frag0 - 16 +16 __pfx_gro_pull_from_frag0 16 - -16 dev_gro_receive 1514 1464 -50 gro_pull_from_frag0 188 - -188 Total: Before=22565899, After=22566015, chg +0.00% Signed-off-by: Eric Dumazet <edumazet@google.com> Link: https://patch.msgid.link/20260122045720.1221017-3-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/net/core/gro.c b/net/core/gro.c
@@ -415,7 +415,7 @@ static void gro_pull_from_frag0(struct sk_buff *skb, int grow)
 {
 	struct skb_shared_info *pinfo = skb_shinfo(skb);
 
-	BUG_ON(skb->end - skb->tail < grow);
+	DEBUG_NET_WARN_ON_ONCE(skb->end - skb->tail < grow);
 
 	memcpy(skb_tail_pointer(skb), NAPI_GRO_CB(skb)->frag0, grow);
 

Original file line number	Diff line number	Diff line change
`@@ -415,7 +415,7 @@ static void gro_pull_from_frag0(struct sk_buff *skb, int grow)`
`415`	`415`	`{`
`416`	`416`	`struct skb_shared_info *pinfo = skb_shinfo(skb);`
`417`	`417`
`418`		`- BUG_ON(skb->end - skb->tail < grow);`
	`418`	`+ DEBUG_NET_WARN_ON_ONCE(skb->end - skb->tail < grow);`
`419`	`419`
`420`	`420`	`memcpy(skb_tail_pointer(skb), NAPI_GRO_CB(skb)->frag0, grow);`
`421`	`421`