Skip to content

Commit e8f3522

Browse files
Afloat16sarlinpe
andauthored
Resolve benchmark paths before changing subprocess directories (colmap#4931)
Problem: Reconstruction subprocesses run inside each scene workspace. Relative data_path and run_path arguments resolve to the wrong locations when the working directory changes. Change: Resolve both paths during argument parsing, alongside the COLMAP executable path. --------- Co-authored-by: Paul-Edouard Sarlin <[email protected]>
1 parent 27ffad4 commit e8f3522

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

  • benchmark/reconstruction/evaluation

‎benchmark/reconstruction/evaluation/utils.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -542,6 +542,9 @@ def parse_args(description: str | None = None) -> argparse.Namespace:
542542
)
543543
args = parser.parse_args()
544544
args.colmap_path = Path(args.colmap_path).resolve()
545+
# Child processes run inside each scene's workspace, not the caller's cwd.
546+
args.data_path = args.data_path.resolve()
547+
args.run_path = args.run_path.resolve()
545548
if args.num_seeds is not None:
546549
if args.num_seeds <= 0:
547550
parser.error("--num_seeds must be > 0")

0 commit comments

Comments
 (0)