You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b5ff5c3
Browse filesBrowse the repository at this point in the historyBrowse files
`RANSAC::Report::num_trials` currently includes reservations that fail
the trial-budget or abort check before sampling. For example, a
one-trial budget reports two iterations with one thread and five with
four threads. A zero-trial budget also reports work that never ran.
`LORANSAC` shares the same reporting error.
I count the iterations that pass both checks with an OpenMP reduction.
The reservation counter, sampling, stopping conditions and model
selection remain unchanged. This also gives accurate trial totals to the
existing fundamental-matrix benchmark.
The two regression tests cover zero, one and five trials with one and
four threads. All 12 count assertions fail on pristine production; all
12 tests across both native modules pass with the fix, both with OpenMP
and with it disabled. A separate 900-call counting matrix confirms that
each report equals the actual minimal-estimator calls. All 108 seeded
similarity-transform model, mask and support controls match pristine
output exactly.
I validated MSVC Release on Windows. Six alternating timing rounds show
median changes from -3.4% to +5.8% across the serial paths, including a
+4.4 us/call no-OpenMP LORANSAC diagnostic. The per-round timings are
noisy; this is a reporting correction without a speed claim.
Changed-file formatting, scoped Clang-Tidy and whitespace checks pass.
Full application, reconstruction-dataset, GPU and other-platform
validation remain unrun.
AI assistance disclosure: AI-assisted development tools were used during
investigation and implementation. The reported tests were run against
the final diff.
---------
Co-authored-by: Johannes Schönberger <[email protected]>
0 commit comments