Skip to content

Fix open .ly file from Finder (macOS) #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fedelibre merged 1 commit into from
Aug 4, 2025
Merged

Fix open .ly file from Finder (macOS) #2051

fedelibre merged 1 commit into from
Aug 4, 2025

Conversation

@inkandpaper-app
Copy link
Contributor

@inkandpaper-app inkandpaper-app commented Jul 26, 2025 •
edited by fedelibre
Loading

Fix #2040 and #1062

@fedelibre fedelibre changed the title Fixes frescobaldi/frescobaldi#2040 Fix open .ly file from Finder (macOS) Jul 26, 2025
@fedelibre
Copy link
Member

fedelibre commented Jul 26, 2025

@inkandpaper-app Thanks for your contribution. Please try to follow this practice for the PR:

  1. The title should describe what you are fixing or adding. It should be as clear as possible, even for a regular user. This title will appear in the Release page.
  2. In order to automatically close the issue you are fixing, the body of your first message here (which is anything below the second line when you make the first commit in git) should contain a Fix #NNNN. Fix is Ok, while Fixes is not.

@fedelibre
Copy link
Member

fedelibre commented Aug 4, 2025

@bmjcode Can you review the code?

bmjcode
bmjcode approved these changes Aug 4, 2025
View reviewed changes
Copy link
Collaborator

@bmjcode bmjcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks clean to me. I don't have a Mac to test it on, but I'm presuming you've confirmed it works @inkandpaper-app.

@inkandpaper-app
Copy link
Contributor Author

inkandpaper-app commented Aug 4, 2025

Yes, at least on my two Mac with the last operating system

@fedelibre fedelibre merged commit f25d11f into frescobaldi:master Aug 4, 2025
@inkandpaper-app inkandpaper-app deleted the issue#2040 branch August 12, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmjcode bmjcode bmjcode approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Double-clicking a document the app, upon first opening, opens a blank document.

3 participants

@inkandpaper-app @fedelibre @bmjcode