Fix snippet shortcuts breaking when a main window is closed #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue here was that we were using a specific window's action collection to track shortcuts, but that collection no longer exists once the window is closed. Fixes frescobaldi#2037.
fedelibre
approved these changes
Jul 27, 2025
Member
fedelibre
left a comment
fedelibre
left a comment
There was a problem hiding this comment.
I can't remember how to trigger this, but I trust you've verified your patch.
Collaborator
Author
|
If you want to check it yourself:
My patch also works if you close the second window instead in step 3. (That doesn't trigger the original bug, but would have been an issue with some of the more trivial fixes I tried.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here was that we were using a specific window's action collection to track shortcuts, but that collection no longer exists once the window is closed.
Fixes #2037.