Changes to the Score Wizard to remove unused variables. #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmjcode
reviewed
Jul 4, 2025
Collaborator
bmjcode
left a comment
bmjcode
left a comment
There was a problem hiding this comment.
I would note in the docstring for PartItem.__init__() that constructing the item automatically adds it to the parts list. PartItem is derived from QTreeWidgetItem, for which this is expected behavior, but that's not immediately obvious here.
bmjcode
approved these changes
Aug 4, 2025
Collaborator
bmjcode
left a comment
bmjcode
left a comment
There was a problem hiding this comment.
Sure, let's go ahead and do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last two instances of
ruff check --select F841have been fixed.