Modifications to remove unused variables #2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmjcode
reviewed
Aug 4, 2025
bmjcode
approved these changes
Aug 4, 2025
Collaborator
bmjcode
left a comment
bmjcode
left a comment
There was a problem hiding this comment.
I'm OK with merging these changes since they don't seem to break anything. That said, I think some of the variable names help clarify the logic for human readers even if they're technically unused in the code. See my comments on pitch/pitch.py for an example.
fedelibre
force-pushed
the
ksnortum-ruff-f841
branch
from
6009db4 to
f2578c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are modifications to fix
ruff check --select F841, unused variables. There are still two outstanding warnings, but those are complex enough that I think they deserve their own PR.