Skip to content

Conversation

@fedelibre
Copy link
Member

to prevent crashes on Windows when opening
the Documentation Browser.

Fix #1979

to prevent crashes on Windows when opening
the Documentation Browser.

Fix #1979
Copy link
Collaborator

@bmjcode bmjcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen that crash here running from source, but if you've confirmed this fixes yours that's good enough for me. (Mine does crash running the 4.0.2 Briefcase package.)

@fedelibre
Copy link
Member Author

It might depend on GPU drivers in your system vs my system (Windows 10). I confirm that on current master it crashes:

test@xps MINGW64 ~/src/frescobaldi (master)
$ py -m frescobaldi
[8016:10048:0622/233500.750:ERROR:shared_image_factory.cc(880)] Could not find SharedImageBackingFactory with params: usage: Gles2Read|DisplayRead|DisplayWrite|Scanout, format: RGBA_8888, share_between_threads: 0, gmb_type: empty, debug_label: QWE_SharedImageBuffer
[8016:10048:0622/233500.751:ERROR:native_skia_output_device.cpp(253)] CreateSharedImage failed.
[8016:10048:0622/233500.752:ERROR:raster_decoder.cc(1146)]   RasterDecoderImpl: Context lost during MakeCurrent.
[8016:10048:0622/233500.753:ERROR:raster_decoder.cc(1146)]   RasterDecoderImpl: Context lost during MakeCurrent.
[8016:10048:0622/233500.770:ERROR:shared_context_state.cc(885)] Failed to make current since context is marked as lost
[8016:10048:0622/233500.770:ERROR:skia_output_surface_impl_on_gpu.cc(2264)] Failed to make current.
[8016:10048:0622/233500.777:ERROR:shared_image_factory.cc(880)] Could not find SharedImageBackingFactory with params: usage: Gles2Read|DisplayRead|DisplayWrite|Scanout, format: RGBA_8888, share_between_threads: 0, gmb_type: empty, debug_label: QWE_SharedImageBuffer
[8016:10048:0622/233500.777:ERROR:native_skia_output_device.cpp(253)] CreateSharedImage failed.
[8016:10048:0622/233500.778:ERROR:raster_decoder.cc(1146)]   RasterDecoderImpl: Context lost during MakeCurrent.
[8016:10048:0622/233500.778:ERROR:raster_decoder.cc(1146)]   RasterDecoderImpl: Context lost during MakeCurrent.
[8016:10048:0622/233500.793:ERROR:shared_context_state.cc(885)] Failed to make current since context is marked as lost
[8016:10048:0622/233500.793:ERROR:skia_output_surface_impl_on_gpu.cc(2264)] Failed to make current.

When I checkout this PR branch it works (some error messages are printed, but everything works fine):

test@xps MINGW64 ~/src/frescobaldi (win-qtwebengineprocess)
$ py -m frescobaldi
[5336:5384:0622/233721.920:ERROR:gpu_channel_manager.cc(956)] Failed to create GLES3 context, fallback to GLES2.
[5336:5384:0622/233721.921:ERROR:gpu_channel_manager.cc(967)] ContextResult::kFatalFailure: Failed to create shared context for virtualization.

Even launching Frescobaldi using briefcase run (inside this PR branch) does not cause the crash.

@fedelibre
Copy link
Member Author

For the records, in another computer (different graphic card) where I have a virtualized Windows 10, version 4.0.3 built by Briefcase runs just fine, no crash.

Anyway, we'd better use these settings for all Windows installations to avoid potential crashes. In order to browse a simple documentation website we do not need GPU rendering, etc.

I'll merge this tonight.

@fedelibre fedelibre merged commit de05606 into master Jun 29, 2025
@fedelibre fedelibre deleted the win-docbrowser-crash branch June 29, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation Browser crash on Windows 10

3 participants