Fix ruff check E713, 'not in' warnings #2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedelibre
reviewed
Jun 20, 2025
Member
fedelibre
left a comment
fedelibre
left a comment
There was a problem hiding this comment.
It looks good to me, but let's wait for Ben's approval
Collaborator
@ksnortum there is the sample extension |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
not <element> in <list>to<element> not in <list>.I was able to test all files except
frescobaldi/vbcl/__init__.py, which has to do with extensions, I think. I couldn't find any Frescobaldi extensions on the web to add and remove, but the change is a trivial one, so I think we're okay.