Skip to content

Conversation

@bmjcode
Copy link
Collaborator

@bmjcode bmjcode commented Jun 20, 2025

This fixes some things I noticed while scrolling through earlier.

Copy link
Member

@fedelibre fedelibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change to one line per paragraph? Breaking a paragraph after n characters (usually 70/90) is quite common. Probably you prefer let your editor window do the breaking automatically?

The rest looks good to me.

@bmjcode
Copy link
Collaborator Author

bmjcode commented Jun 20, 2025

@fedelibre I don't see the point of breaking lines within paragraphs for formats like Markdown and HTML. The formatter ignores those breaks and any sane text editor can wrap long lines automatically. Breaking manually just creates unnecessary work for human editors if they need to change something mid-paragraph.

Copy link
Member

@fedelibre fedelibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I think I'm used to this "old school" practice, but after thinking more on it I'm convinced that one line per paragraph is better.

@ksnortum
Copy link
Contributor

Can I make one minor suggestion? Line 144, "Change existing files as less as possible." to "Change existing files as little as possible."

@bmjcode
Copy link
Collaborator Author

bmjcode commented Jun 22, 2025

@ksnortum Good catch. Done.

@bmjcode bmjcode merged commit 7d21e69 into frescobaldi:master Jun 22, 2025
@bmjcode bmjcode deleted the contributing-format branch June 22, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants