Skip to content

Conversation

@ksnortum
Copy link
Contributor

Fix two instances of bare excepts:

$ ruff check --select E722
All checks passed!

@bmjcode
Copy link
Collaborator

bmjcode commented Jun 20, 2025

I think this is fine, but since signals.py is the kind of relatively low-level code that sometimes needs to bend the rules, I want to come back and look at it with fresh eyes before approving anything.

Copy link
Collaborator

@bmjcode bmjcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was overthinking this before. Let's go ahead and merge this. I don't see how it would break anything in normal use. If it did somehow break something, it would be at such a low level that we'd have bigger problems.

@bmjcode bmjcode merged commit 639b0a1 into frescobaldi:master Jul 4, 2025
@ksnortum ksnortum deleted the ksnortum-ruff-e722 branch August 11, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants