Fix a call to an obsolete method in the ViewManager event handler #2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedelibre
requested changes
Jun 14, 2025
Member
fedelibre
left a comment
fedelibre
left a comment
There was a problem hiding this comment.
It's not the unique occurrence. There are others to be fixed:
$ git grep -nw globalPos
frescobaldi/doclist/widget.py:158: menu.exec(doc, ev.globalPos())
frescobaldi/doclist/widget.py:197: menu.exec(ev.globalPos())
frescobaldi/quickinsert/buttongroup.py:180: QToolTip.showText(ev.globalPos(), text)
frescobaldi/quickinsert/buttongroup.py:188: m.exec(ev.globalPos())
frescobaldi/tabbar.py:188: self.contextMenu().exec(self.docs[index], ev.globalPos())
frescobaldi/viewers/pdfwidget.py:207: editinplace.edit(self, cursor, ev.globalPos())
frescobaldi/widgets/charmap.py:204: QToolTip.showText(ev.globalPos(), text, self, rect)
frescobaldi/widgets/charmap.py:217: QWhatsThis.showText(ev.globalPos(), text, self)
frescobaldi/widgets/imageviewer.py:128: self._startpos = ev.globalPos()
frescobaldi/widgets/imageviewer.py:131: diff = self._startpos - ev.globalPos()
frescobaldi/widgets/imageviewer.py:133: self._startpos = ev.globalPos()
frescobaldi/widgets/imageviewer.py:144: mode == DRAG and ev.globalPos() == self._startpos):
Member
|
Maybe there are other deprecated methods. |
Collaborator
Author
|
@fedelibre Some (most?) of those handle different types of events. For example, the one in You know I'm quite comfortable programming with |
Member
|
Ok, I thought it was a changed needed everywhere. |
fedelibre
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2002.