Use Pygame Community Edition #1987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
We have a problem with macOS signing @jacques-menu @davidfokkema Any help is appreciated. |
fedelibre
added a commit
that referenced
this pull request
Jun 3, 2025
This fork re-enables MIDI output on macOS. Fix #1946
Collaborator
|
Hello Federico,
I’m no signing guru unfortunately…
What can I do to help solve this?
JM
… Le 3 juin 2025 à 11:39, Federico Bruni ***@***.***> a écrit :
fedelibre
left a comment
(frescobaldi/frescobaldi#1987)
<#1987 (comment)>
We have a problem with macOS signing <https://github.com/frescobaldi/frescobaldi/actions/runs/15413337567/job/43370248757>
[frescobaldi] Notarizing DMG with team ID ***...
Submitting app for notarization... started
Submitting app for notarization... done
Briefcase will now wait for Apple to approve the notarization request.
This can take some time - in some cases, hours.
If notarization is interrupted, you can resume by running:
briefcase package macOS app -p dmg --identity 7122EF914A5E99A9E7693F242E1865E964C48242 --resume 33b2cb95-7ef0-4cca-9d3f-343d22f5a02c
Waiting for notarization acceptance... started
Waiting for notarization acceptance... errored
Notarization was rejected: Archive contains critical validation errors
* (error) Frescobaldi-4.0.3.dev1.dmg/Frescobaldi.app/Contents/MacOS/Frescobaldi [x86_64]
The signature of the binary is invalid.
https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087735
* (error) Frescobaldi-4.0.3.dev1.dmg/Frescobaldi.app/Contents/MacOS/Frescobaldi [arm64]
The signature of the binary is invalid.
https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087735
Saving log... started
Log saved to /Users/runner/work/frescobaldi/frescobaldi/logs/briefcase.2025_06_03-09_26_18.package.log
Saving log... done
Error: Process completed with exit code 200.
@jacques-menu <https://github.com/jacques-menu> @davidfokkema <https://github.com/davidfokkema> Any help is appreciated.
—
Reply to this email directly, view it on GitHub <#1987 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRJX6SNS6SVINVCARNU4CL3BVUO7AVCNFSM6AAAAAB6O44NN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMZUGM4DMOJXG4>.
You are receiving this because you were mentioned.
|
|
I'm trying to check on things locally. If I run briefcase package on my machine, I get the same error in the notarization step. I'll try out a few things. |
Member
Author
|
Thanks David, I can test only via GitHub Action. I've just added the following step to see if we get more information. I've launched now the workflow: |
|
Without local access the turnaround time is quite long. I just ran that command for example, and it complains it can only handle .pkg installer files and does not check .dmg disk image files or .app application bundles. I tried checking using codesign --verify but that keeps saying that all is well. I also just confirmed that the exact same version of briefcase still signs the master branch without problems, so I'll work my way up from there. |
|
The problem appears to be |
|
I can confirm that this seems to be correct and that even for a minimal Briefcase pygame app, this is the case: 2.5.4 fails, 2.5.3 works. |
Member
Author
|
Many thanks David! We'll stick to 2.5.3 until this is fixed upstream. |
This fork re-enables MIDI output on macOS. Fix #1946
bmjcode
approved these changes
Jun 5, 2025
Collaborator
bmjcode
left a comment
bmjcode
left a comment
There was a problem hiding this comment.
I can confirm this works on Windows with 2.5.3. I'm good with merging this.
JunTamura1959
pushed a commit
to JunTamura1959/frescobaldi
that referenced
this pull request
Jun 7, 2025
This fork re-enables MIDI output on macOS. Fix frescobaldi#1946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork re-enables MIDI output on macOS.
Fix #1946