Skip to content

Conversation

@JunTamura1959
Copy link
Contributor

@JunTamura1959 JunTamura1959 commented May 21, 2025

"Page layout" in the Music View section of the Preferences window was not translated.

Copy link
Member

@fedelibre fedelibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've added two translations and removed two translations. Is this really what you want to do?

@JunTamura1959
Copy link
Contributor Author

There is one new translation for: "Page layout"
One correction for: "Staff group"
Two deletions for: "Output filename:", "Include octave indication"
The one correction and the two deletions are for the ones originally suggested by the Poedit, which I overlooked. I've found where in the UI the "Staff group" appears, I mean, I understand the context. I could not find where in the UI the "Output filename:" and "Include octave indication" appear, so I decided to leave them untranslated.

@fedelibre
Copy link
Member

I could not find where in the UI the "Output filename:" and "Include octave indication" appear, so I decided to leave them untranslated.

I think that these strings are self explanatory and you don't really need to know where they appear in the UI in order to translate them.
However, for better understanding, Poedit has a View>Show Code Occurences menu item, which shows where the string is used in the code. This should help a little bit. For example, look at this:

Screenshot From 2025-05-26 20-30-57

The file location in the top left tells you where it appears: the score wizard and specifically the containers part. There's also a doc string which explains everything.

You can use the same method for any string.

I hope it helps. You can add more commits to this PR if you want.

@bmjcode
Copy link
Collaborator

bmjcode commented May 26, 2025

I could not find where in the UI the "Output filename:" and "Include octave indication" appear, so I decided to leave them untranslated.

"Include octave indication" is used for guitar parts in the Score Wizard. It toggles between treble_8 clef and standard clef transposed an octave down.

@JunTamura1959
Copy link
Contributor Author

@fedelibre @bmjcode Thanks for your advice. Do you have any schedule for the 4.0.3 release? If it's a few weeks away, then I would fix the above and add a few more.

@fedelibre
Copy link
Member

I don't have any plan at the moment. I would say not before the 10/15 of June.

@JunTamura1959 JunTamura1959 marked this pull request as draft May 27, 2025 13:29
@JunTamura1959
Copy link
Contributor Author

@fedelibre Thanks! I will translate a bit more by 10th June.

@fedelibre
Copy link
Member

@JunTamura1959 Friendly reminder: I confirm I'll make a new release next week on 9th or 10th. In case you want to complete this PR before the new release...

@JunTamura1959
Copy link
Contributor Author

@fedelibre Thank you for the reminder. I'll complete the PR by the end of Sunday (Japan time; around noon EU time).

bmjcode and others added 5 commits June 7, 2025 21:02
This adds standard logic in app.py to select an appropriate default
editor font for each platform (generally that used by the system text
editor: Notepad on Windows, TextEdit on macOS, etc.).

My original intention was simply to provide a sane default for macOS,
but since this is used in multiple places I thought a more robust
implementation would benefit all platforms.
This fork re-enables MIDI output on macOS.
Fix frescobaldi#1946
@JunTamura1959 JunTamura1959 deleted the ja-update branch June 7, 2025 12:17
@JunTamura1959 JunTamura1959 mentioned this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants