Add Ctrl+, shortcut to open the Preferences #1952
Conversation
|
I've added a comment in the code to explain why we do not use I know that a user might set this shortcut in the Preferences, but many users are lazy and might not even know they can do it. What do you think? |
bmjcode
left a comment
bmjcode
left a comment
There was a problem hiding this comment.
Looks good to me -- though I would suggest adding that Ctrl+, is a Mac shortcut in case anyone wonders why that specific combination.
|
Ok, I will do it. I can't find a default shortcut for Windows. But
|
Qt doesn't have a default keyboard shortcut for GNOME and Windows to open the Preferences¹, so a default shortcut is currently missing in these platforms. We can force Ctrl+, which is the default on macOS as well as in GNOME² and it's also very common on some popular crossplatform editors. This is a partial fix for #887 ¹ https://doc.qt.io/qt-6/qkeysequence.html#standard-shortcuts ² https://developer.gnome.org/hig/reference/keyboard.html
|
I tried improving both the comment and the commit message |
|
I've opened QTBUG-137059 |
GNOME and Windows¹ do not have a standard keyboard shortcut to open the Preferences so there's no default shortcut in these platforms. We can force Ctrl+, which is the default on macOS but it's also very common on some popular crossplatform editors.
This is a partial fix for #887
¹ https://doc.qt.io/qt-6/qkeysequence.html#standard-shortcuts