Make mainwidget an instance attribute so it's not garbage-collected #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a widget to a layout changes its parent to the widget on which the layout is installed. Here the layout is on self.mainwidget, and the tab bar and view manager become its children. Thus if mainwidget is a local variable, the tab bar and view manager are garbage-collected when the constructor returns and mainwidget goes out of scope, even though they were constructed with the MainWindow instance as their parent. Hopefully this finally fixes the infamous frescobaldi#1467.
bmjcode
force-pushed
the
mainwidget-parent
branch
from
86d436e to
e98b689
Compare
Member
Collaborator
Author
I think all the "wrapped C/C++ object has been deleted" errors share the same root cause, so this should fix all of them. Edit: Assuming I'm right about what the problem is, which is always a big if. :) |
This was referenced May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a widget to a layout changes its parent to the widget on which the layout is installed. Here the layout is on
self.mainwidget, and the tab bar and view manager become its children. Thus ifmainwidgetis a local variable, the tab bar and view manager are garbage-collected when the constructor returns andmainwidgetgoes out of scope, even though they were constructed with theMainWindowinstance as their parent.Hopefully this finally fixes the infamous #1467.