Make MIDI input work again on Windows >=10 #1922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Here's a .msi file containing this patch: |
bmjcode
approved these changes
Apr 11, 2025
Collaborator
bmjcode
left a comment
bmjcode
left a comment
There was a problem hiding this comment.
It is a typo. Compare the setting names from preferences/midi.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #853
Honestly, I don't have much understanding of the code but at a first glance it may just be a typo. I would appreciate a review from a programmer :-)
I can only say that it works.
Thanks to @drydh for his analysis in #853.