-
Notifications
You must be signed in to change notification settings - Fork 171
Reorganize Preferences #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Preferences #1920
Conversation
|
I'm happy with the changes. I'm keeping it as draft, as I have to remember to update the user manual. But I'd like to have some feedback first. See also the screenshots I put in issue #1414 |
|
@bmjcode I've rebased it and updated the documentation. |
|
Looks good. Just a couple points: The page list on the left is slightly too narrow to display the full labels on mine. Can it be made a hair wider? Also, the manual mentions an external printing command can be set on Windows and macOS. That's not actually the case on any platform, as a quick glance through preferences/musicviewers.py will confirm. (With the move to QtPdf, everything is now printed as a raster image.) |
|
On Linux at startup (with no previous conf file present), the preferences appear very shrinked: then you can drag the window and the size is remembered. So it's not a big deal... but sure it could be improved. I see a better behaviour with the left sidebar on Linux. When I shrink the window horizontally to the minimum it never cuts the preferences on the left: |
So the tooltip in Preferences>Music View>Resolution saying "Set the resolution if Frescobaldi prints using raster images" is not accurate? If everything is now printed as a raster image, we'd better say something like "Set the resolution for printing (as Frescobaldi prints the music as raster image)". The part of the manual about printing doesn't seem accurate anymore:
I can't find the Use Frescobaldi's print dialog option in the code. Maybe it's been removed? Here's what I see in the print dialog: |
PDF uses vectors, but both screens and printers are raster devices, so it has to be rendered to a raster image either way. In qpageview >= 1.0.0 that happens in qpageview.pdf.PdfRenderer.draw(). The same logic is used for both kinds of devices. Poppler provided a so-called vector backend, but all that really did was offload rasterization to Poppler itself. Since printers operate at a fixed resolution the final output was still a raster image. Note that QPrinter.setResolution() only "requests that the printer prints at dpi or as near to dpi as possible". So if that preference is set to 300dpi but your printer only supports 600dpi, the PDF will print at 600dpi. You might phrase that in the manual as "the closest resolution supported by your printer will be used" and "if unsure, leave this set to the default".
I agree. I only ever print from Frescobaldi to test that code since I seem to be maintaining it now. :)
It must have been removed some time ago. I don't recall ever seeing it on any platform. |
|
Thanks for the detailed explanation. I've added one more commit |
bmjcode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.





Fix #1414