Use Qt6 enums in MIDI input #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #1916
bmjcode
approved these changes
Apr 10, 2025
Collaborator
bmjcode
left a comment
bmjcode
left a comment
There was a problem hiding this comment.
Looks good to me. This specific replacement is one of my pet peeves with PyQt6. Qt.Modifier and Qt.KeyboardModifier are supposed to be interchangeable, but they are not in PyQt6 because of how it implements enum types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1916
@bmjcode I found this bug while preparing a patch for the user manual. I want to add some instructions for MIDI playback and MIDI input.
I see that there are other
Qt.Modifieruses in the code that should be probably modified? I'm not confident with Qt and programming in general...https://doc.qt.io/qt-6/qt.html#KeyboardModifier-enum