Skip to content

Conversation

@jeanas
Copy link
Member

@jeanas jeanas commented Apr 4, 2025

It has much better defaults for files to include/exclude and is generally just a lot saner than setuptools. This parallels the changes

frescobaldi/python-ly#165
frescobaldi/qpageview#23

It has much better defaults for files to include/exclude and is generally
just a lot saner than setuptools. This parallels the changes

frescobaldi/python-ly#165
frescobaldi/qpageview#23
@jeanas
Copy link
Member Author

jeanas commented Apr 4, 2025

Wait, there's an issue with the MO files…

@jeanas jeanas marked this pull request as draft April 4, 2025 23:00
@fedelibre
Copy link
Member

Wait, there's an issue with the MO files…

What issue?
If I generate the mo files and then run python -m build, I can see the mo files in the tarball.

@fedelibre
Copy link
Member

@jeanas Can you please tell use which issue you had with the MO files?

@jeanas jeanas marked this pull request as ready for review April 18, 2025 16:46
@jeanas
Copy link
Member Author

jeanas commented Apr 18, 2025

I re-tested today, no issues. Not sure what I did wrong last time.

Should we merge it?

@fedelibre fedelibre merged commit c1dee00 into frescobaldi:master Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants