Don't return None from battery pool methods#612
Merged
shsms merged 1 commit intofrequenz-floss:v0.x.xfrom Sep 5, 2023
Merged
Conversation
stefan-brus-frequenz
force-pushed
the
bp_sample_none
branch
from
06ec6b2 to
4f6a114
Compare
llucax
changed the title
None from battery pool methods (#545)None from battery pool methods
stefan-brus-frequenz
force-pushed
the
bp_sample_none
branch
from
4f6a114 to
53edd73
Compare
github-actions
bot
added
part:docs
stefan-brus-frequenz
force-pushed
the
bp_sample_none
branch
5 times, most recently
from
c1f6c3f to
054027a
Compare
shsms
reviewed
Aug 29, 2023
Contributor
shsms
left a comment
shsms
left a comment
There was a problem hiding this comment.
Just a couple of comments, LGTM otherwise.
stefan-brus-frequenz
force-pushed
the
bp_sample_none
branch
7 times, most recently
from
a6e0b60 to
ab8a49c
Compare
shsms
reviewed
Aug 29, 2023
stefan-brus-frequenz
force-pushed
the
bp_sample_none
branch
2 times, most recently
from
097e091 to
8602909
Compare
shsms
previously approved these changes
Aug 29, 2023
Contributor
|
I'm guessing this needs to be rebased, for the old requirements to go away. |
Contributor
YES! (But it is more "for the new requirements to be met) |
stefan-brus-frequenz
force-pushed
the
bp_sample_none
branch
from
8602909 to
4bb6046
Compare
Contributor
Author
|
rebase'd |
In the case when no battery is available, the internal values of the `Sample` or `PowerMetric` will be set to `None`, instead. Signed-off-by: Stefan Brus <[email protected]>
stefan-brus-frequenz
force-pushed
the
bp_sample_none
branch
from
4bb6046 to
206e56c
Compare
shsms
approved these changes
Sep 5, 2023
shsms
added a commit
to shsms/frequenz-sdk-python
that referenced
this pull request
Sep 16, 2023
It looks like only the `MetricCalculator`s were updated in a previous PR (frequenz-floss#612) and some parts where still pending. This is taken care of here. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added a commit
to shsms/frequenz-sdk-python
that referenced
this pull request
Sep 20, 2023
It looks like only the `MetricCalculator`s were updated in a previous PR (frequenz-floss#612) and some parts where still pending. This is taken care of here. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added a commit
to shsms/frequenz-sdk-python
that referenced
this pull request
Sep 20, 2023
It looks like only the `MetricCalculator`s were updated in a previous PR (frequenz-floss#612) and some parts where still pending. This is taken care of here. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added a commit
to shsms/frequenz-sdk-python
that referenced
this pull request
Sep 21, 2023
It looks like only the `MetricCalculator`s were updated in a previous PR (frequenz-floss#612) and some parts where still pending. This is taken care of here. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added a commit
to shsms/frequenz-sdk-python
that referenced
this pull request
Sep 21, 2023
It looks like only the `MetricCalculator`s were updated in a previous PR (frequenz-floss#612) and some parts were still pending. This is taken care of here. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added a commit
to shsms/frequenz-sdk-python
that referenced
this pull request
Sep 22, 2023
It looks like only the `MetricCalculator`s were updated in a previous PR (frequenz-floss#612) and some parts were still pending. This is taken care of here. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added a commit
to shsms/frequenz-sdk-python
that referenced
this pull request
Sep 27, 2023
It looks like only the `MetricCalculator`s were updated in a previous PR (frequenz-floss#612) and some parts were still pending. This is taken care of here. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added a commit
to shsms/frequenz-sdk-python
that referenced
this pull request
Sep 27, 2023
It looks like only the `MetricCalculator`s were updated in a previous PR (frequenz-floss#612) and some parts were still pending. This is taken care of here. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added a commit
to shsms/frequenz-sdk-python
that referenced
this pull request
Sep 27, 2023
It looks like only the `MetricCalculator`s were updated in a previous PR (frequenz-floss#612) and some parts were still pending. This is taken care of here. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added a commit
to shsms/frequenz-sdk-python
that referenced
this pull request
Oct 4, 2023
It looks like only the `MetricCalculator`s were updated in a previous PR (frequenz-floss#612) and some parts were still pending. This is taken care of here. Signed-off-by: Sahas Subramanian <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case when no battery is available, the internal values of the
SampleorPowerMetricwill be set toNoneinstead.