Conversation
We don't want to have duplicated paths between extra and source paths either, otherwise things will be processed twice. Signed-off-by: Leandro Lucarella <[email protected]>
When copying these dataclasses we also need to copy the lists that they hold, otherwise if there are in-place updates the copied instances will be affected too. Signed-off-by: Leandro Lucarella <[email protected]>
The documentation was outdated. Signed-off-by: Leandro Lucarella <[email protected]>
API repos use a non-standard directory to store tests (`pytests`), because of this, the directory should be configured in `pyproject.toml` and since we auto-discover test directories from there, there is no need to keep the hack that will add `pytests` to the `extra_paths` for API repos. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
When pressing ENTER while being asked for project keywords, an empty
keyword ("") was added. This commit fixes that.
Signed-off-by: Leandro Lucarella <[email protected]>
This is because mkdocs doesn't render numbered lists correctly if they
have more than one paragraph using less than 4 spaces indentation.
For example, this:
```md
1. A list item.
This list item gets improperly rendered.
```
Gets rendered like this in HTML:
```html
<ol>
<li><p>A list item./<p></li>
</o>
<p>This list item gets improperly rendered.</p>
```
While this:
```md
1. A list item.
This list item gets improperly rendered.
```
Gets rendered like this in HTML:
```html
<ol>
<li>
<p>A list item.</p>
<p>This list item gets improperly rendered.</p>
</li>
</o>
```
Signed-off-by: Leandro Lucarella <[email protected]>
The file in `src/frequenz/` could conflict with other packages, and we really need to provide the file for the whole `frequenz.repo` package as it is the top-level package here, so we can do `from frequenz.repo import config`. Signed-off-by: Leandro Lucarella <[email protected]>
There are a lot of files that are only used for development purposes and should not be distributed in the source distribution package, as this package should only include the files necessary to build the wheel. We still ship basic documentation (like the README, release notes and license as they are very lightweight and carry important information). Signed-off-by: Leandro Lucarella <[email protected]>
There are a lot of files that are only used for development purposes and should not be distributed in the source distribution package, as this package should only include the files necessary to build the wheel. We still ship basic documentation (like the README, release notes and license as they are very lightweight and carry important information). Signed-off-by: Leandro Lucarella <[email protected]>
Marenz
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigandCommandOptionsdefaults.api_configdocumentationpytestsdirectorymkdocs.ymlimport inventories