Refactor models to improve performance#1266
Merged
frenck merged 1 commit intofrenck:mainfrom May 14, 2024
Merged
Conversation
bdraco
force-pushed
the
improve_performance
branch
from
9416fc4 to
8ef5f92
Compare
- Avoid many linear searchs - Cache version construction
bdraco
force-pushed
the
improve_performance
branch
from
8ef5f92 to
7894430
Compare
Contributor
Author
|
Tested with single and multisegments. I only have 2 wled devices to test with though, and this PR was the result of reviewing user performance data in beta |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
Owner
|
Not stale |
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
Contributor
Author
|
keep-alive |
github-actions
bot
removed
the
stale
frenck
approved these changes
May 14, 2024
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The linear searches produce 100000s of dict gets per minute with ~25 devices