Skip to content

Meta fixes#2

Merged
fregante merged 5 commits intomasterfrom
meta
Apr 17, 2021
Merged

Meta fixes#2
fregante merged 5 commits intomasterfrom
meta

Conversation

@fregante
Copy link
Owner

No description provided.

@sitiom
Copy link
Contributor

sitiom commented Apr 17, 2021

git push origin HEAD:testing-branch

Putting the full ref qualifier git push origin HEAD:refs/heads/testing-branch makes it work.

@fregante
Copy link
Owner Author

No I don’t think that's the issue, the current code works on push events but not on pull_request events due to a permission issue. This sounds like GitHub is giving a token with reduced permissions to PRs, as expected.

@fregante fregante marked this pull request as ready for review April 17, 2021 10:15
@fregante fregante merged commit 6cef8bf into master Apr 17, 2021
@fregante fregante deleted the meta branch April 17, 2021 10:22
@sitiom
Copy link
Contributor

sitiom commented Apr 17, 2021

git push origin HEAD:testing-branch

Putting the full ref qualifier git push origin HEAD:refs/heads/testing-branch makes it work.

This works as tested here:

@fregante fregante mentioned this pull request Apr 17, 2021
@fregante
Copy link
Owner Author

Can you send this PR from your fork? https://github.com/fregante/setup-git-user/pull/3/files

It's weird that they'd allow a fork to push to either repo

@sitiom
Copy link
Contributor

sitiom commented Apr 17, 2021

Can you send this PR from your fork? https://github.com/fregante/setup-git-user/pull/3/files

It's weird that they'd allow a fork to push to either repo

Yeah fails to work. The problem now is about remotes.

@fregante
Copy link
Owner Author

Yeah, so it defeats the purpose of being included for PRs.

Thanks for working with me on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants