Skip to content

Use the actual GitHub Actions bot email#1

Merged
fregante merged 1 commit intofregante:masterfrom
sitiom:patch-1
Apr 17, 2021
Merged

Use the actual GitHub Actions bot email#1
fregante merged 1 commit intofregante:masterfrom
sitiom:patch-1

Conversation

@sitiom
Copy link
Contributor

@sitiom sitiom commented Apr 17, 2021

@fregante
Copy link
Owner

The current value already works like in your screenshot, as can be seen on https://github.com/fregante/daily-version-action/releases

Screen Shot 1

@sitiom
Copy link
Contributor Author

sitiom commented Apr 17, 2021

The current value already works like in your screenshot, as can be seen on https://github.com/fregante/daily-version-action/releases

Screen Shot 1

However, in the commits and the commit history, it doesn't show up as expected
Github Actions commit
It doesn't correctly point to the github-actions bot.

@fregante
Copy link
Owner

Indeed https://github.com/fregante/github-url-detection/commits/master

@fregante
Copy link
Owner

However this email doesn't work at all, as can be seen in the live demo. I think we should drop the [bot] part since it's likely irrelevant anyway, they only use the user ID

@sitiom
Copy link
Contributor Author

sitiom commented Apr 17, 2021

However this email doesn't work at all, as can be seen in the live demo. I think we should drop the [bot] part since it's likely irrelevant anyway, they only use the user ID

What live demo are you talking about anyway, dependabot uses the same format on their commits.

dependabot commit

@fregante
Copy link
Owner

I wanted to ensure that my test still works on its own, so I opened #2

You can see the workflow script here: https://github.com/fregante/setup-git-user/actions/runs/758199116/workflow

      - name: Run Action
        uses: ./
      - name: Test the action by creating and deleting a commit
        run: |
          git commit --allow-empty --message 'git test'
          git push origin HEAD:testing-branch
          git push --delete origin testing-branch

It's a plain commit and push. In this PR it's failing because the user is being rejected

@sitiom
Copy link
Contributor Author

sitiom commented Apr 17, 2021

I wanted to ensure that my test still works on its own, so I opened #2

You can see the workflow script here: https://github.com/fregante/setup-git-user/actions/runs/758199116/workflow

      - name: Run Action
        uses: ./
      - name: Test the action by creating and deleting a commit
        run: |
          git commit --allow-empty --message 'git test'
          git push origin HEAD:testing-branch
          git push --delete origin testing-branch

It's a plain commit and push. In this PR it's failing because the user is being rejected

Oh I see now, the origin remote is set to this repo instead of my fork, so it failed.

@fregante
Copy link
Owner

Actually no, it's failing in my PR too. I'm guessing that the PR test can't push back to the repo with the included token 🤔

@fregante
Copy link
Owner

I'll have to disable the test on PRs. Let me merge that PR with a fix and then I'll merge this

@fregante fregante merged commit 5ede2be into fregante:master Apr 17, 2021
@fregante fregante added the enhancement New feature or request label Apr 17, 2021
@sitiom sitiom deleted the patch-1 branch April 17, 2021 09:56
@fregante
Copy link
Owner

Indeed it works on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants