Skip to content

Conversation

@Oliver0804
Copy link
Contributor

Add Traditional Chinese (Taiwan) translations

@andrasfuchs
Copy link
Collaborator

This is great stuff, thank you a lot @Oliver0804! 🥇

Note to myself: add zh_tw to the supported languages in the GlobalSettings.java as well.

@Oliver0804
Copy link
Contributor Author

This is great stuff, thank you a lot @Oliver0804! 🥇

Note to myself: add zh_tw to the supported languages in the GlobalSettings.java as well.

Thank you for your assistance. If any adjustments are needed, I will make the necessary changes.

@Oliver0804
Copy link
Contributor Author

@andrasfuchs
I have already made some changes to GlobalSettings.java. Could you please check if they are correct?
截圖 2024-06-26 凌晨12 38 43

@andrasfuchs
Copy link
Collaborator

I made two small changes before the merge:

  • I changed the order or language checks, because "zh" and "zh-TW" both start with "zh" so we need to check for "zh-TW" first
  • I made the parameter checking case insensitive and it now accepts both "zh-TW" and "zh_TW" as valid values

Thanks @Oliver0804 again for your work! 👍

@andrasfuchs andrasfuchs merged commit 9d5b1e2 into freerouting:master Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants