Refactor #224
Merged
Refactor #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify things and dispose properly
Some files were CRLF, convert to LF
Contributor
Author
|
Ok, I've just realized it's quite big 😂😂😂 |
Collaborator
|
Outstanding, thank you very much @maksz42! I'll get into it next week, and let you know how it goes! |
andrasfuchs
approved these changes
Sep 21, 2023
Collaborator
|
According to my first few tests everything looks good! And the new dialog definitely looks better. I just wanted to note that I noticed that you changed the location of the counter to the other button: It was strange at first to be honest, but the more I see it the more I like it. I'll get back to you when I did a more complete test, hopefully I can merge this PR next week the latest. |
Contributor
Author
|
I think it's more natural that the timer counts down the default option, like "Starting in 10, 9, 8...". |
Collaborator
|
I've just merged your PR, thanks again for your work @maksz42! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I tried to bring the codebase a bit closer to modern Java, as it looks like a big part comes from before Java 5. I tried my best not to break anything. There are no changes to the router engine (at least not intended 🙃). As a side effect, there is ~10% performance improvement coming probably from more efficient array copying. I also fixed small GUI bugs.