Skip to content

Don't hardcode JRE version #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrasfuchs merged 5 commits into from
Sep 22, 2023
Merged

Don't hardcode JRE version #201

andrasfuchs merged 5 commits into from
Sep 22, 2023

Conversation

@maksz42
Copy link
Contributor

@maksz42 maksz42 commented May 26, 2023

Use Adoptium API

maksz42 added 2 commits May 26, 2023 01:56
@maksz42
Don't hardcode JRE version
ede1174 
Use Adoptium API
@maksz42
Make sure java exe is a file
ccf5761 
a little defensive programming
@freerouting freerouting deleted a comment Sep 19, 2023
@andrasfuchs
Copy link
Collaborator

andrasfuchs commented Sep 19, 2023

This looks good, I just need to copy the code over into the plugin.py as well, and test it when it runs within the KiCad plugin both on Windows and Linux (especially if KiCad was installed using Flatpak).

@andrasfuchs andrasfuchs merged commit 046123b into freerouting:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maksz42 @andrasfuchs