Skip to content

improve Java version checking #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrasfuchs merged 1 commit into from
Feb 16, 2023
Merged

improve Java version checking #169

andrasfuchs merged 1 commit into from
Feb 16, 2023

Conversation

@Riesi
Copy link
Contributor

@Riesi Riesi commented Feb 15, 2023

This fixes an issue with assuming that the first line of java -version contains the java version when it doesnt for openJDK when having a configuration option set.

Issue:

$ java -version
Picked up _JAVA_OPTIONS: -Djava.util.prefs.userRoot=/home/stefan/.config/java
openjdk version "17.0.6" 2023-01-17
OpenJDK Runtime Environment (build 17.0.6+10)
OpenJDK 64-Bit Server VM (build 17.0.6+10, mixed mode)

@andrasfuchs andrasfuchs mentioned this pull request Feb 15, 2023
Closed
9 tasks
@andrasfuchs
Copy link
Collaborator

andrasfuchs commented Feb 16, 2023

Looks great, thank you @Riesi!

@andrasfuchs andrasfuchs merged commit 2e45e97 into freerouting:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Riesi @andrasfuchs