Skip to content

Update Network.read_net_pins() to handle DSN files exported from eagle #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrasfuchs merged 1 commit into from
Oct 13, 2022
Merged

Update Network.read_net_pins() to handle DSN files exported from eagle #147

andrasfuchs merged 1 commit into from
Oct 13, 2022

Conversation

@Rezer
Copy link
Contributor

@Rezer Rezer commented Sep 23, 2022 •
edited
Loading

Updated to properly handle quoted component/pin pairings, e.g. (pins "comp1"-"pin1" "comp2"-"pin4")

@Rezer
Update Network.read_net_pins() to handle DSN files exported from eagle
4353f75 
Updated to properly handle quoted quoted component/pin pairings, e.g. (pins "comp1"-"pin1" "comp2"-"pin4")
@Rezer Rezer mentioned this pull request Sep 23, 2022
Closed
9 tasks
@andrasfuchs
Copy link
Collaborator

andrasfuchs commented Oct 13, 2022

I created a new file named 'Issue143-rpi_splitter_mod.dsn' in the tests folder and modified its network section as follows:

(network
    (net "D+"
      (pins "J3-"-"D+" "J1"-"D+")
    )
    (net "D-"
      (pins "J3{"-"D-" "J1"-"D-")
    )
    (net "N$5"
      (pins "J2(--)"-"GND" "J3"-"GND" "J1 + - ( )"-"GND")
    )
    (net "VBUS"
      (pins "J3 -+"-"_VBUS #22")
    )
    (net "VCC"
      (pins J2-VBUS "J1"-VBUS)
    )
  )

They were read all correctly with your modifications, so I'll merge your PR.

Thank you for this patch @Rezer!

@andrasfuchs andrasfuchs merged commit ee19a1f into freerouting:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rezer @andrasfuchs