Temp commit#8075
Closed
sumit-bose wants to merge 1 commit into
Closed
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The COPR name
packit/SSSD-sssd-8267is hard-coded in multiple jobs and looks specific to a single build; consider parameterizing it or clearly marking this as a temporary override so it’s easy to revert back to@sssd/nightlywhen no longer needed. .freeipa-pr-ci.yamlnow has its only line removed and becomes effectively empty, which may disable PR CI; double-check that this file is still intended to be used and either restore or replace the reference toipatests/prci_definitions/gating.yaml.- Given the PR title is
Temp commit, it would be helpful to rename the PR (and possibly add a comment in the YAML) to clarify the longer-term intent of these CI configuration changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The COPR name `packit/SSSD-sssd-8267` is hard-coded in multiple jobs and looks specific to a single build; consider parameterizing it or clearly marking this as a temporary override so it’s easy to revert back to `@sssd/nightly` when no longer needed.
- `.freeipa-pr-ci.yaml` now has its only line removed and becomes effectively empty, which may disable PR CI; double-check that this file is still intended to be used and either restore or replace the reference to `ipatests/prci_definitions/gating.yaml`.
- Given the PR title is `Temp commit`, it would be helpful to rename the PR (and possibly add a comment in the YAML) to clarify the longer-term intent of these CI configuration changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
sumit-bose
force-pushed
the
sssd_upstream_test_pr8267
branch
3 times, most recently
from
December 19, 2025 13:13
fcc487b to
c2003cf
Compare
sumit-bose
force-pushed
the
sssd_upstream_test_pr8267
branch
from
December 22, 2025 12:34
c2003cf to
1c30d6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update SSSD nightly CI configuration to use a specific Packit Copr build instead of the generic nightly repository and adjust PR CI configuration accordingly.
CI: