Temp commit#8055
Closed
sumit-bose wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The same
copr: 'packit/SSSD-sssd-8296'value is repeated across many jobs innightly_latest_sssd.yaml; consider introducing a YAML anchor or a top-level variable for this copr so it’s easier to switch back or adjust in one place later. - The change to
.freeipa-pr-ci.yamlremoves the existing path without adding a replacement; if that’s intentional, it might be clearer to either delete the file entirely or update it to point to the intended CI definition instead of leaving it effectively empty.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The same `copr: 'packit/SSSD-sssd-8296'` value is repeated across many jobs in `nightly_latest_sssd.yaml`; consider introducing a YAML anchor or a top-level variable for this copr so it’s easier to switch back or adjust in one place later.
- The change to `.freeipa-pr-ci.yaml` removes the existing path without adding a replacement; if that’s intentional, it might be clearer to either delete the file entirely or update it to point to the intended CI definition instead of leaving it effectively empty.
## Individual Comments
### Comment 1
<location> `ipatests/prci_definitions/nightly_latest_sssd.yaml:46` </location>
<code_context>
class: Build
args:
- copr: '@sssd/nightly'
+ copr: 'packit/SSSD-sssd-8296'
git_repo: '{git_repo}'
git_refspec: '{git_refspec}'
</code_context>
<issue_to_address>
**suggestion:** Factor out the COPR identifier to avoid repeating the same literal across all jobs.
If this COPR is temporary or likely to change, define `'packit/SSSD-sssd-8296'` once (e.g., via a top-level YAML anchor/variable) and reference it from all jobs to avoid duplication and inconsistencies on future updates.
Suggested implementation:
```
job:
class: Build
args:
copr: &sssd_copr 'packit/SSSD-sssd-8296'
git_repo: '{git_repo}'
git_refspec: '{git_refspec}'
template: &ci-master-latest
args:
build_url: '{sssd-fedora/build_url}'
update_packages: True
copr: *sssd_copr
test_suite: test_integration/test_commands.py
template: *ci-master-latest
timeout: 5400
args:
```
Search the rest of `ipatests/prci_definitions/nightly_latest_sssd.yaml` for any other occurrences of the literal `copr: 'packit/SSSD-sssd-8296'` and replace them with `copr: *sssd_copr` to ensure all jobs consistently reuse the same COPR definition.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| class: Build | ||
| args: | ||
| copr: '@sssd/nightly' | ||
| copr: 'packit/SSSD-sssd-8296' |
There was a problem hiding this comment.
suggestion: Factor out the COPR identifier to avoid repeating the same literal across all jobs.
If this COPR is temporary or likely to change, define 'packit/SSSD-sssd-8296' once (e.g., via a top-level YAML anchor/variable) and reference it from all jobs to avoid duplication and inconsistencies on future updates.
Suggested implementation:
job:
class: Build
args:
copr: &sssd_copr 'packit/SSSD-sssd-8296'
git_repo: '{git_repo}'
git_refspec: '{git_refspec}'
template: &ci-master-latest
args:
build_url: '{sssd-fedora/build_url}'
update_packages: True
copr: *sssd_copr
test_suite: test_integration/test_commands.py
template: *ci-master-latest
timeout: 5400
args:
Search the rest of ipatests/prci_definitions/nightly_latest_sssd.yaml for any other occurrences of the literal copr: 'packit/SSSD-sssd-8296' and replace them with copr: *sssd_copr to ensure all jobs consistently reuse the same COPR definition.
This was referenced Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Switch nightly SSSD CI jobs to use a specific Packit COPR build instead of the default nightly repository.
CI: